Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayonly disables the caption and therefore the value could only be guessed (reopen) #188

Closed
5 of 6 tasks
Bhoft opened this issue Sep 18, 2018 · 1 comment
Closed
5 of 6 tasks

Comments

@Bhoft
Copy link
Contributor

Bhoft commented Sep 18, 2018

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest master branch of bootstrap-star-rating.
  • This is not an usage question. I confirm having read the plugin documentation and demos.
  • This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
  • I have attempted to find the simplest possible steps to reproduce the issue.
  • I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

This is a issue is still existing
#177

Thanks for adding the display caption as title mode but there is still one issue.
In my code I have the possibility to show the caption as a title, so you see the current value on hover.
But also (and this isn't possible in your version) show the caption as well.

This is needed e.g. if you create a pdf from the html code and the value of the rating is not integer but some decimal value (like 3.4 of 5).
With only the "stars" it is not correctly visible if the rating is 3.4 or 3.5 or ..

So it should be possible to also print out the caption the same way as the rating shows in input mode.

Expected behavior and actual behavior

When I follow those steps, I see...

I was expecting to have enable also the caption.
image

But even if i enable it by showCaption => true it is disabled by your displayOnly mode.

if (self.displayOnly) {
self.inactive = true;
self.showClear = false;
self.showCaption = false;

You shoudn't set showCaption to false automatically when displayOnly mode is enabled.

@kartik-v
Copy link
Owner

kartik-v commented Oct 4, 2018

Resolved via update to release v4.0.5.

@kartik-v kartik-v closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants