You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the only solution to have an output of the current value is to echo it manually.
which is of course possible but it would be useful that the caption could be enabled or at least give the div of the widget a title =" with the value" so the value is shown at least on hover.
i tried to set inactive = true, showClear = false manually but then the inactive state is overwritten by self.inactive = (self.disabled || self.readonly); in the _checkDisabled function.
I didn't wanted to prevent to set readOnly' => true, or 'disabled' => true, through the normal options as this would then would change the cursor: not-allowed;.
Will this bug be fixed soon?
Should i create a pull request and remove just the causing line of code?
Or do you think of adding additional features in the newer versions like alt / title attributes for the div to display the current value in display mode?
Thanks @Bhoft and wish you the same. Unfortunately not got a time to look at it... it would be great if you could help with a PR that is extensible. I will anyway look at it a bit when I get time.
Prerequisites
master
branch of bootstrap-star-rating.Steps to reproduce the issue
create a display only StarRating like
with displayOnly = true no caption is rendered. because it is disabled in the js code. there is no way to enable it manually.
the only solution to have an output of the current value is to echo it manually.
which is of course possible but it would be useful that the caption could be enabled or at least give the div of the widget a title =" with the value" so the value is shown at least on hover.
i tried to set inactive = true, showClear = false manually but then the inactive state is overwritten by
self.inactive = (self.disabled || self.readonly);
in the _checkDisabled function.I didn't wanted to prevent to set
readOnly' => true,
or'disabled' => true,
through the normal options as this would then would change thecursor: not-allowed;
.A solution could also be that the caption isn't disabled by default when displayOnly is true but then could be set manually that it is hidden.
So remove this line https://github.com/kartik-v/bootstrap-star-rating/blob/master/js/star-rating.js#L256
btw merry christmas :)
Environment
Browsers
Operating System
Libraries
Isolating the problem
The text was updated successfully, but these errors were encountered: