Update dialog asset loading sequence

kartik-v · Sep 4, 2018 · d81debb · d81debb
1 parent becec01
commit d81debb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/src/Dialog.php b/src/Dialog.php
@@ -188,7 +188,7 @@ class Dialog extends Widget
     /**
      * @var integer the registration position for the Krajee dialog JS client code.
      */
-    public $jsPosition = View::POS_READY;
+    public $jsPosition = View::POS_HEAD;
 
     /**
      * @inheritdoc

diff --git a/src/DialogAsset.php b/src/DialogAsset.php
@@ -31,6 +31,7 @@ class DialogAsset extends AssetBundle
      */
     public function init()
     {
+        $this->jsOptions = ['position' => View::POS_HEAD];
         $this->setSourcePath(__DIR__ . '/assets');
         $this->setupAssets('js', ['js/dialog']);
         parent::init();

diff --git a/src/DialogBootstrapAsset.php b/src/DialogBootstrapAsset.php
@@ -23,6 +23,7 @@ class DialogBootstrapAsset extends PluginAssetBundle
      */
     public function init()
     {
+        $this->depends = array_merge(['kartik\dialog\DialogAsset'], $this->depends);
         $this->setSourcePath(__DIR__ . '/assets');
         $this->setupAssets('js', ['js/bootstrap-dialog']);
         $this->setupAssets('css', ['css/bootstrap-dialog-bs' . ($this->isBs4() ? '4' : '3')]);

diff --git a/src/DialogYiiAsset.php b/src/DialogYiiAsset.php
@@ -24,10 +24,10 @@ class DialogYiiAsset extends AssetBundle
      * @inheritdoc
      */
     public $depends = [
-        'yii\web\YiiAsset',
         'kartik\dialog\DialogAsset',
+        'yii\web\YiiAsset',
     ];
-    
+
     /**
      * @inheritdoc
      */