Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting page summary colspan direction (ltr or rtl) #906

Closed
wants to merge 1 commit into from
Closed

Allow setting page summary colspan direction (ltr or rtl) #906

wants to merge 1 commit into from

Conversation

wiltonlcsj
Copy link

@wiltonlcsj wiltonlcsj commented May 17, 2019

Added the possibility to choose the side of column pageSummaryOptions['colspan'] must merge (left or right side) using pageSummaryOptions['colSpanDir'] attribute at column level.
Otherwise, today the colspan only works LTR so i've added the possibility of RTL merge.

Scope

This pull request includes a

  • New feature

Related Issues

#902

@wiltonlcsj wiltonlcsj closed this May 17, 2019
@wiltonlcsj wiltonlcsj reopened this May 17, 2019
@kartik-v kartik-v changed the title Adding possibility to choose the of the horizontal position of merge colspan Adding page summary colspan direction May 17, 2019
@kartik-v kartik-v changed the title Adding page summary colspan direction Allow setting page summary colspan direction (ltr or rtl) May 17, 2019
@kartik-v kartik-v closed this in f00d893 May 17, 2019
@kartik-v
Copy link
Owner

kartik-v commented May 17, 2019

Resolved via above enhancement. You need to set pageSummaryOptions['data-colspan-dir'] to one of either ltr or rtl.

@kartik-v
Copy link
Owner

You can refer an example in the grid demo.

To see the column configuration in the demo go to the page above and in the demo configuration page section below --- click on the button Code for $gridColumns

@wiltonlcsj
Copy link
Author

This will be merge at the next release or at current?

@kartik-v
Copy link
Owner

Next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants