Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sortable.php #1

Merged
merged 1 commit into from
Aug 12, 2014
Merged

Update Sortable.php #1

merged 1 commit into from
Aug 12, 2014

Conversation

zmedanic
Copy link
Contributor

$ shortname for jQuery in asset registration is breaking script.
Need to be changed by jQuery name instead.

@kartik-v
Copy link
Owner

Should not break the script... ensure your jquery assets are loaded before the plugin assets.

@zmedanic
Copy link
Contributor Author

They are.
Basically, code is generated as:

<script type="text/javascript">jQuery(document).ready(function () { jQuery('#w1').sortableInput(sortableInput_f2fc9476) jQuery('#w1-sortable').sortable(sortable_45d5605d); $("#w1-sortable").sortable('enable'); It fails to recognize $ as jQuery.

kartik-v added a commit that referenced this pull request Aug 12, 2014
@kartik-v
Merge pull request #1 from zmedanic/master
c51e413 
Update Sortable.php
@kartik-v kartik-v merged commit c51e413 into kartik-v:master Aug 12, 2014
@kartik-v
Copy link
Owner

Probably you may have conflict with $ being used as another function name somewhere... merged this now.

@spiritdead spiritdead mentioned this pull request Jun 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zmedanic @kartik-v