Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ensure types #194

Closed
wants to merge 11 commits into from
Closed

Conversation

TimiBolu
Copy link

@TimiBolu TimiBolu commented Oct 8, 2023

No description provided.

@kartikk221
Copy link
Owner

Hey, there seem to be a ton of changes in your PR. Could you breakdown what changes are made / the overall goal of this PR? Thanks!

From my brief look, It seems you have converted all the source code modules into typescript files and setup a distribution system. This package was created with JSDoc mainly for ease of development as a library and without having to deal with building TypeScript. While TypeScript is great for almost every project, I felt that JSDoc would be sufficient for hyper-express given the modular nature of the library.

@TimiBolu
Copy link
Author

TimiBolu commented Oct 9, 2023

Hey, there seem to be a ton of changes in your PR. Could you breakdown what changes are made / the overall goal of this PR? Thanks!

From my brief look, It seems you have converted all the source code modules into typescript files and setup a distribution system. This package was created with JSDoc mainly for ease of development as a library and without having to deal with building TypeScript. While TypeScript is great for almost every project, I felt that JSDoc would be sufficient for hyper-express given the modular nature of the library.

Thanks a lot for reviewing this. I didn't mean to make a PR. Instead, I wanted to rewrite the library in TypeScript primarily for learning purposes so I could better understand how backend servers work and their challenges.

@TimiBolu TimiBolu closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants