New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "reject" to handle Request.json error #243

Merged

kartikk221 merged 1 commit into kartikk221:master from Jiahonzheng:fix/request-json-error-handling

Apr 2, 2024

Contributor

Jiahonzheng commented Apr 1, 2024 •

edited

This PR contains the following changes:

Use "Promise.reject" to handle JSON parsing error mentioned in No error thrown if invalid json is sent as body #215.
Update comments. When passing "default_value" as "undefined", it would still be set to "{}" and it won't enter Line 541 error-catch statement.


          fix: use reject to handle json parsing error

2c98a2d

Use "Promise.reject" to handle JSON parsing error.
Update comments.

kartikk221 merged commit 1f36125 into kartikk221:master

optixyt0 mentioned this pull request

[Snyk] Upgrade hyper-express from 6.7.1 to 6.16.1 optixyt0/Momentum#6

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment