Add grunt, linting, enable in travis-ci and make pass

.eslintrc.json

@@ -0,0 +1,15 @@
+{
+	"extends": "kartotherian",
+	"rules": {
+		"comma-dangle": [2,"never"],
+		"one-var": [2,"always"],
+		"no-param-reassign": [2,{"props":false}],
+		"no-plusplus": [2,{"allowForLoopAfterthoughts": true}]
+	},
+	"env": {
+		"browser": true
+	},
+	"globals": {
+		"L": false
+	}
+}

.stylelintrc.json

@@ -0,0 +1,8 @@
+{
+	"extends": "stylelint-config-wikimedia",
+	"rules": {
+		"declaration-no-important": null,
+		"selector-max-id": null,
+		"indentation": 2
+	}
+}

.travis.yml

@@ -0,0 +1,6 @@
+language: node_js
+node_js:
+  - "4"
+  - "8"
+before_script:
+  - npm install grunt-cli -g

Gruntfile.js

@@ -0,0 +1,34 @@
+/* eslint-env node */
+module.exports = function Gruntfile(grunt) {
+  grunt.loadNpmTasks('grunt-contrib-watch');
+  grunt.loadNpmTasks('grunt-eslint');
+  grunt.loadNpmTasks('grunt-stylelint');
+
+  grunt.initConfig({
+    eslint: {
+      code: {
+        src: [
+          '**/*.js',
+          '!node_modules/**',
+          '!vendor/**',
+          '!tests/externals/**',
+          '!static/lib/**'
+        ]
+      }
+    },
+    // Lint – Styling
+    stylelint: {
+      options: {
+        syntax: 'less'
+      },
+      all: [
+        'static/**/*.css',
+        '!static/lib/**'
+      ]
+    }
+  });
+
+  grunt.registerTask('lint', ['eslint', 'stylelint']);
+  grunt.registerTask('test', 'lint');
+  grunt.registerTask('default', 'test');
+};

lib/.eslintrc.json

@@ -0,0 +1,7 @@
+{
+	"extends": "../.eslintrc.json",
+	"env": {
+		"node": true,
+		"es6": true
+	}
+}

lib/info.js

@@ -1,17 +1,8 @@
-'use strict';
+const infoHeaders = {},
+  util = require('util'),
+  Promise = require('bluebird');
 
-let util = require('util'),
-    Promise = require('bluebird');
-
-let core,
-    infoHeaders = {};
-
-module.exports = function info(cor, router) {
-    core = cor;
-
-    // get source info (json)
-    router.get('/:src(' + core.Sources.sourceIdReStr + ')/info.json', requestHandler);
-};
+let core;
 
 /**
  * Web server (express) route handler to get requested tile or info
@@ -20,23 +11,30 @@ module.exports = function info(cor, router) {
  * @param next will be called if request is not handled
  */
 function requestHandler(req, res, next) {
-    let source,
-        start = Date.now();
-
-    return Promise.try(() => {
-        source = core.getPublicSource(req.params.src);
-        return source.getHandler().getInfoAsync().then(info => [info, infoHeaders]);
-    }).spread((data, dataHeaders) => {
-        core.setResponseHeaders(res, source, dataHeaders);
+  const start = Date.now();
+  let source;
+
+  return Promise.try(() => {
+    source = core.getPublicSource(req.params.src);
+    return source.getHandler().getInfoAsync().then(info => [info, infoHeaders]);
+  }).spread((data, dataHeaders) => {
+    core.setResponseHeaders(res, source, dataHeaders);
+
+    if (req.query && req.query.format) {
+      const escapedText = JSON.stringify(data, null, ' ').replace(/&/g, '&amp;').replace(/</g, '&lt;');
+      res.send(`<pre>${escapedText}</pre>`);
+    } else {
+      res.json(data);
+    }
+
+    const mx = util.format('req.%s.info', req.params.src);
+    core.metrics.endTiming(mx, start);
+  }).catch(err => core.reportRequestError(err, res)).catch(next);
+}
 
-        if (req.query && req.query.format) {
-            let escapedText = JSON.stringify(data, null, ' ').replace(/&/g, '&amp;').replace(/</g, '&lt;');
-            res.send('<pre>' + escapedText + '</pre>');
-        } else {
-            res.json(data);
-        }
+module.exports = function info(cor, router) {
+  core = cor;
 
-        let mx = util.format('req.%s.info', req.params.src);
-        core.metrics.endTiming(mx, start);
-    }).catch(err => core.reportRequestError(err, res)).catch(next);
-}
+  // get source info (json)
+  router.get(`/:src(${core.Sources.sourceIdReStr})/info.json`, requestHandler);
+};

lib/server.js

@@ -1,42 +1,38 @@
-'use strict';
-
-let Promise = require('bluebird'),
-    pathLib = require('path'),
-    express = require('express'),
-    compression = require('compression');
-
-module.exports.init = function(opts) {
-
-    return Promise.try(function () {
-        let router = express.Router(),
-            handlers = opts.requestHandlers || [];
-
-        handlers.unshift(require('./tiles'), require('./info'));
-        return Promise.mapSeries(handlers, function (reqHandler) {
-            return reqHandler(opts.core, router);
-        }).return(router);
-
-    }).then(function (router) {
-        // Add before static to prevent disk IO on each tile request
-        let app = opts.app,
-            staticOpts = {
-                setHeaders: function (res) {
-                    if (app.conf.cache) {
-                        res.header('Cache-Control', app.conf.cache);
-                    }
-                    if (res.req.originalUrl.endsWith('.pbf')) {
-                        res.header('Content-Encoding', 'gzip');
-                    }
-                }
-            };
-
-        app.use('/', router);
-
-        // Compression is nativelly handled by the tiles, so only statics need its
-        app.use(compression());
-        app.use('/', express.static(pathLib.resolve(__dirname, '../static'), staticOpts));
-        app.use('/leaflet', express.static(pathLib.dirname(require.resolve('leaflet')), staticOpts));
-
-        opts.core.metrics.increment('init');
-    });
+const Promise = require('bluebird'),
+  pathLib = require('path'),
+  express = require('express'),
+  compression = require('compression'),
+  tiles = require('./tiles'),
+  info = require('./info');
+
+module.exports.init = function init(opts) {
+  return Promise.try(() => {
+    const router = express.Router(),
+      handlers = opts.requestHandlers || [];
+
+    handlers.unshift(tiles, info);
+    return Promise.mapSeries(handlers, reqHandler => reqHandler(opts.core, router)).return(router);
+  }).then((router) => {
+    // Add before static to prevent disk IO on each tile request
+    const { app } = opts,
+      staticOpts = {
+        setHeaders(res) {
+          if (app.conf.cache) {
+            res.header('Cache-Control', app.conf.cache);
+          }
+          if (res.req.originalUrl.endsWith('.pbf')) {
+            res.header('Content-Encoding', 'gzip');
+          }
+        }
+      };
+
+    app.use('/', router);
+
+    // Compression is nativelly handled by the tiles, so only statics need its
+    app.use(compression());
+    app.use('/', express.static(pathLib.resolve(__dirname, '../static'), staticOpts));
+    app.use('/leaflet', express.static(pathLib.dirname(require.resolve('leaflet')), staticOpts));
+
+    opts.core.metrics.increment('init');
+  });
 };