Added extra options for geoserver #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NyakudyaA
commented
Feb 25, 2018
•
NyakudyaA
commented
- Added a download script to install plugins in Geoserver. The script should be run before building the image. Some common plugins should be preinstalled in the image (ie control-flow, GDAL, WPS, Image pyramid)
- Added GDAL data directory and environment variables to ensure when a user installs the Gdal plugins Geoserver recognizes them.
- Moved the java environment settings to the docker file so that the image contains built-in optimizations.
- Modified build script so that when building the image locally you only specify the GeoServer version once in the download script and it changes all occurrences in other files. Example Dockerfile and download.sh.
- Added more instructions in the readme including how to use a persistent storage with sample data from GeoServer war file.
- Added a sample file for use with the control flow module.
- Install libjpeg-turbo- An extension which provides a significant performance enhancement for JPEG encoding in GeoServer WMS output
- Install extra fonts which are used by SLD with graphic markers
gubuntu
reviewed
Mar 7, 2018
Dockerfile
Outdated
| @@ -106,7 +153,7 @@ RUN rm -f /tmp/resources/overlays/README.txt && \ | |||
| fi; | |||
|
|
|||
| # Optionally remove Tomcat manager, docs, and examples | |||
| ARG TOMCAT_EXTRAS=true | |||
| #ARG TOMCAT_EXTRAS=true #moved to docker-compose.yml | |||
| RUN if [ "$TOMCAT_EXTRAS" = false ]; then \ | |||
There was a problem hiding this comment.
because the previous line has been moved to docker-compose, this will always be false and therefore run - delete it? Or should it run?
There was a problem hiding this comment.
It should always be true. The arguments are substituted when building the image. So in the docker-compose, it would be
args:
- ORACLE_JDK=true
- TOMCAT_EXTRAS=false
|
LGTM - just address my one comment then merge (and test after merging) |
gubuntu
reviewed
Mar 7, 2018
README.md
Outdated
| The Tomcat properties such as maximum heap memory size are included in the Dockerfile. You need to change them | ||
| them before building the image in accordance to the resources available on your server: | ||
|
|
||
| The default settings in the image are: |
There was a problem hiding this comment.
I would delete this section - if the default settings change then this would have to be maintained
There was a problem hiding this comment.
I will delete that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.