Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to import PR into entries #1133

Merged
merged 5 commits into from
Feb 13, 2020

Conversation

anitanh
Copy link
Contributor

@anitanh anitanh commented Feb 11, 2020

fix #1128

This PR:

  • Added function to fetched PRs from github
  • Added modal in version detail view to import PRs from github
  • Added form validation

Note:

Peek 2020-02-11 12-06

How to use

  1. Click on the github icon on the right side of the page, it will open a pop up to import the PRs.
  2. The repository url is filled automatically but should you like to import the PR from another repository you can fill it here too (required).
  3. Wait until the label options is rendered.
  4. Select the label of which you want to import the PR, if you select more than one label it will only fetch the PR containing all of the selected labels.
  5. Select the state of the PR, it can be open or closed or both, if you don't select any it will fetch all PR regardless open or closed.
  6. Select a category where the new entries will be associated to (required).
  7. Click import, it will begin fetching your PRs and rendering them into entries.

@anitanh
Copy link
Contributor Author

anitanh commented Feb 11, 2020

Travis error is unrelated to this PR

@dimasciput
Copy link
Member

Hi @Ann26 , shouldn't this be like an automated process? User doesn't need to do this manually, instead when there is a new PR with specific label, it will create an entry in changelog?
What do you think @timlinux ?

@timlinux
Copy link
Contributor

Hi @Ann26 and @dimasciput

I'm OK with it being a manual process for now but there are a few more things maybe I missed to mention in the original ticket:

We need to be able to specify a time box or at least a starting point so that we don't fetch PR's from before the current release cycle.

It's not clear from your GIF but do you bring image references through?

Do we have logic in place to prevent duplicate entries?

Ideally in the future ,yes, I would like the process to be automated, with the options you provide in the dialog moved into the project properties page so that any new incomiing PR's get added to the latest current changelog. We need a flag to mark a version 'open' or 'closed' to indicate whether new entries may be added to the latest changelog. I would keep the manual tool around too.

@anitanh
Copy link
Contributor Author

anitanh commented Feb 13, 2020

hi @timlinux

It's not clear from your GIF but do you bring image references through?

by image references do you mean the image in the PR? yes it will be in the entries too.

Do we have logic in place to prevent duplicate entries?

No, but if we want to create one, how do we determine that it is a duplicate? If it is the title, I think it is possible to have the same title and yet different PR e.g. update on feature etc

We need to be able to specify a time box or at least a starting point so that we don't fetch PR's from before the current release cycle.

I will add the time box

@timlinux
Copy link
Contributor

No, but if we want to create one, how do we determine that it is a duplicate? If it is the title, I think it is possible to have the same title and yet different PR e.g. update on feature etc

Simply having the same PR url - can you add a PR url field to then entry model for this purpose:

image

@anitanh
Copy link
Contributor Author

anitanh commented Feb 13, 2020

@timlinux ah okay, I will do, I will create a separate PR with the time constraints and duplicate handler later

@anitanh anitanh merged commit 0aeb60c into kartoza:django2.2 Feb 13, 2020
dimasciput added a commit to dimasciput/projecta that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants