add curriculum models #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlinux
reviewed
Feb 6, 2018
| class Curriculum(models.Model): | ||
| """Curriculum lesson model. | ||
|
|
||
| A curriculum is a grouping for one or more worksheets. |
| from lesson.models.worksheet import Worksheet | ||
|
|
||
|
|
||
| class CurriculumWorksheets(models.Model): |
There was a problem hiding this comment.
I wonder why we can't just use a manytomany field in the curriculum model. See https://docs.djangoproject.com/en/2.0/topics/db/examples/many_to_many/
There was a problem hiding this comment.
Correct me if I'm wrong, but we can't because we have the sequence number field on the relationship.
https://docs.djangoproject.com/en/dev/topics/db/models/#extra-fields-on-many-to-many-relationships
There was a problem hiding this comment.
Ah good point - LGTM then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add models for the curriculum
#740