This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Fix Issue #42 to improve content identification #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r text in p tags will include all text in subtags, e.g. strong, em tags
|
Thanks! As this is no longer maintained from me: would you mind looking at the other failing test cases? Maybe you have to just remove them as some URLs are no longer valid or find something on those domains? |
rborer
pushed a commit
to finity-ai/snacktory
that referenced
this pull request
Aug 12, 2016
We get slightly less content with our implementation (probably because of karussell#47).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When text has formatting, e.g., strong, b, em, tags in it the weightChildNodes in ArticleTextExtractor ignores data. This change uses all text under a p tag to calculate the child's weight score. Subsequently this improves identifying the main area of text. An additional test case has been created to show this working.