[IDNA] Documentation improvements, performance improvements #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
The biggest issue is still the NFC normalization, which comes from Foundation and requires bridging, etc. Using the standard library NFC instead is way faster:
But even that could be much better. We're still buffering everything in a string, and profiling shows that is by far the biggest performance hit. That's just because of how the stdlib SPI happens to be exposed; it could offer something far more efficient and help us cut that out (also,
isNFC
could be way faster than we're doing it here).So yeah - better NFC normalization APIs are what we need to really make a significant dent.