Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut key bindings #27

Closed
dhardy opened this issue Dec 17, 2019 · 2 comments
Closed

Shortcut key bindings #27

dhardy opened this issue Dec 17, 2019 · 2 comments
Labels
discussion Requires analysis/discussion external blocker public API Design of public interface

Comments

@dhardy
Copy link
Collaborator

dhardy commented Dec 17, 2019

Issue: on X11, the calculator doesn't support some keyboard shortcuts, e.g. Asterisk for multiply and Return.

Also concerns Wayland: the key remapping situation is similar.

Blocker: rust-windowing/winit#1266

@dhardy
Copy link
Collaborator Author

dhardy commented May 4, 2020

#100 introduces several unicode → VirtualKeyCode mappings. Quite a few of the obvious bindings for ASCII chars are missing.

What this should do beyond ASCII isn't obvious: unicode is huge and quite a number of the characters could have one (or more) corresponding keys in VirtualKeyCode. This probably depends on what happens to VirtualKeyCode; watch the above-linked winit PR and the issues linked from that.

@dhardy dhardy added discussion Requires analysis/discussion public API Design of public interface labels Feb 23, 2022
@dhardy dhardy changed the title Improved key-binding support [linux] Shortcut key bindings Feb 23, 2022
@dhardy
Copy link
Collaborator Author

dhardy commented Jul 16, 2022

This is not really an issue now (at least, the specific key bindings are fixed).

Winit will likely deprecate VirtualKeyCode entirely at some point. We don't need to track this here.

@dhardy dhardy closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires analysis/discussion external blocker public API Design of public interface
Projects
None yet
Development

No branches or pull requests

1 participant