TabStack widget; fix animations for invisible/transient toggle-boxes; revise container ctors; PixmapScaling #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unwanted animations in MenuToggle (did start when next visible) and in a view widget (did animate when scrolling). Caveat: fade-out animation for a radiobox in a view widget is lost (but fade-in animation remains).
Limitation: only support one widget with flashing cursor(s)
These are little used and the type is not obvious
Also fix aspect-ratio for SpriteDisplay without raw_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main item is the introduction of a new
TabStackwidget. The Gallery now includes Markdown parsing and a Canvas:Limitation: this just uses a
TextButtonfor tabs for now. The active tab isn't highlighted (except when the button is focussed as here).Checkbox and radiobox theme animations are now driven by an extra parameter (time of last change) passed from the widget, since attempting to deduce this in theme code isn't reliable (this fixes the delayed animation on clicking "disabled" in the menu, then re-opening the menu).
Container widgets over a
Vecof children now have constructorsnew()andnew_vec(widgets).What was
SpriteDisplayhas been simplified and improved a little, and renamed toPixmapScaling.