Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iri2pref #63

Merged
merged 4 commits into from Jan 29, 2016
Merged

Iri2pref #63

merged 4 commits into from Jan 29, 2016

Conversation

Varadinsky
Copy link
Contributor

Hi Greg,

This is my first attempt to address the #54 issue as part of the CPAN PRC :-)

Looking forward to your feedback!

Thanks,

Zoran


} else {

return $html;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this have an HTML link, too, with $html as both the href and the link text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Looks like I will have to modify the t/serializer-sparqlhtml.t too since some tests expect the plain IRIs. Or perhaps you want this change only when there is URI::NamespaceMap instance?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it done whether or not there's a namespace map.

I was planning on merging your test file with t/serializer-sparqlhtml.t anyway. So if you don't want to do that, I can take care of it during the merge.

@kasei
Copy link
Owner

kasei commented Jan 29, 2016

Hi Zoran. This looks like a great PRC patch. I added one comment asking for a small change. Other than that, this looks good to merge. Thanks!

@Varadinsky
Copy link
Contributor Author

Hi Greg,
Thanks for the feedback! I updated the serializer and tests.

@kasei kasei merged commit 98724f7 into kasei:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants