Skip to content

Commit

Permalink
perf(backend): JSON.parse の呼び出しを削減する (misskey-dev#11091)
Browse files Browse the repository at this point in the history
* perf(backend): JSON.parse の呼び出しを削減する

Co-authored-by: Hidekazu Kobayashi <kobahide789@gmail.com>

* Update CHANGELOG.md

---------

Co-authored-by: Hidekazu Kobayashi <kobahide789@gmail.com>
  • Loading branch information
riku6460 and KOBA789 committed Jul 3, 2023
1 parent 84d3a06 commit 61e7eb8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
- Fix: サーバーメトリクスが90度傾いている
- Fix: sparkle内にリンクを入れるとクリック不能になる問題の修正

### Server
- JSON.parse の回数を削減することで、ストリーミングのパフォーマンスを向上しました

## 13.13.2

### General
Expand Down
16 changes: 11 additions & 5 deletions packages/backend/src/server/api/StreamingApiServerService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ export class StreamingApiServerService {
});
});

const globalEv = new EventEmitter();

this.redisForSub.on('message', (_: string, data: string) => {
const parsed = JSON.parse(data);
globalEv.emit('message', parsed);
});

this.#wss.on('connection', async (connection: WebSocket.WebSocket, request: http.IncomingMessage, ctx: {
stream: MainStreamConnection,
user: LocalUser | null;
Expand All @@ -112,12 +119,11 @@ export class StreamingApiServerService {

const ev = new EventEmitter();

async function onRedisMessage(_: string, data: string): Promise<void> {
const parsed = JSON.parse(data);
ev.emit(parsed.channel, parsed.message);
function onRedisMessage(data: any): void {
ev.emit(data.channel, data.message);
}

this.redisForSub.on('message', onRedisMessage);
globalEv.on('message', onRedisMessage);

await stream.listen(ev, connection);

Expand All @@ -137,7 +143,7 @@ export class StreamingApiServerService {
connection.once('close', () => {
ev.removeAllListeners();
stream.dispose();
this.redisForSub.off('message', onRedisMessage);
globalEv.off('message', onRedisMessage);
this.#connections.delete(connection);
if (userUpdateIntervalId) clearInterval(userUpdateIntervalId);
});
Expand Down

0 comments on commit 61e7eb8

Please sign in to comment.