Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to versions catalog #224

Merged
merged 4 commits into from
Oct 16, 2022
Merged

Migrate to versions catalog #224

merged 4 commits into from
Oct 16, 2022

Conversation

indyfromoz
Copy link
Contributor

This PR updates the project setup to add a dependency versions catalog and update the configuration based on the new catalog. I have split the changes to three separate commits to aid with the code review.

Some notes -

  1. I have tried my best to use bundles but in the Gradle files but there are no major benefits as bundles could include only 1 or 2 dependencies.
  2. I had to bump up the jvmargs as the compiler was throwing a out of memory exception. Happy to revert the changes if it is not acceptable.
  3. I have updated some of the dependencies to their latest versions and removed some duplicates.
  4. We could convert the Groovy-based build.gradle files into Kotlin script in the future.

I have compiled the app with Android Studio Dolphin | 2021.3.1.Patch1 and tested on a Pixel 6/Android 12 device.

Could you please review the changes?

Closes #155

@kasem-sm
Copy link
Owner

Hey @indyfromoz, I see that you did a great job of cleaning up the buildSrc mess. I also learnt about the bundles section in toml file from this PR. Looks good to me atm. Just one suggestion, can you please completely get rid of the buildSrc folder and App.kt file (as it is unneeded and I guess we can either hard-code the values of appVersion, etc. or find some other way).

Thank you for your current contribution 🥇

@indyfromoz
Copy link
Contributor Author

Hello @kasem-sm!

Thank you for reviewing my PR and really appreciate your help & comments.
I am doing a new commit with your suggested changes.

@indyfromoz
Copy link
Contributor Author

@kasem-sm Added a new commit for the suggested change. I will investigate a way to set SDK versions in a better way.

Kindly review the changes.

@kasem-sm
Copy link
Owner

Thank you for your contribution. ✨

@kasem-sm kasem-sm merged commit 52c6545 into kasem-sm:dev Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to version catalogs (gradle)
2 participants