Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiver link to a PV can't be established if the PV name has macro inside. #405

Closed
claudio-rosati opened this issue Jun 12, 2018 · 3 comments

Comments

@claudio-rosati
Copy link
Collaborator

I report the problem my colleague Miklós Boros found.

The problem is that the .plt editor (DataBrowser) checks the PV name and the Archiver server availability even in design mode.

Step1: search a PV in the Archiver Browser after you have a valid archiver IP set in the preferences.
Step2: drag&drop it into the .plt editor (DataBrowser).

It works.

Now change the PV name so it contains a macro.For example:

(CrS-PHS:Cryo-PI-3130:Pressure) -> (CrS-PHS:Cryo-PI-${Tank}30:Pessure)

The link to the archiver server is immediately deleted, because it can't resolve the macro in design time.

Solution to this is to allow the user to connect the PV to the archiver manually too. This is why we have right click in the bottom of my attached screen. Display Builder should not check the current availability of the PV nor the Archiver server only in runtime mode.

screenshot-1
screenshot-2

@kasemir
Copy link
Owner

kasemir commented Jun 12, 2018

The display builder knows if its in edit mode or not, so yes, it should pass that info down into the Data Browser controller which then skips the archive optimization. I'll do that next week when back from the meeting.

@claudio-rosati
Copy link
Collaborator Author

Thank you.

kasemir added a commit that referenced this issue Jun 19, 2018
.. which have not been resolved, yet.
Simply ignore them when fetching data until the macro is resolved.

#405
kasemir added a commit to ControlSystemStudio/phoebus that referenced this issue Jun 19, 2018
.. which have not been resolved, yet.
Simply ignore them when fetching data until the macro is resolved.

kasemir/org.csstudio.display.builder#405
@kasemir
Copy link
Owner

kasemir commented Jun 19, 2018

Has been fixed, the archive data source is no longer removed for channels that contain macros which are to be resolved later.

@kasemir kasemir closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants