fsql "SELECT * from . WHERE size > 1gb" doesn't work

[christiangenco]

If I run a query like in the README gif it works:

$ fsql "SELECT * from . WHERE name LIKE mkv AND size > 1gb"
...lots of results

but taking away the name LIKE mkv clause breaks it:

$ fsql "SELECT * from . WHERE size > 1gb"
2017/06/09 22:52:28 strconv.ParseFloat: parsing "1gb": invalid syntax

[kashav]

Hey @christiangenco, thanks for the issue!

That syntax for size units was actually removed as of v0.2.0 (haven't gotten around to updating the GIF yet).

What you're actually looking for is:

$ fsql "SELECT * FROM . WHERE FORMAT(size, GB) > 1"

I think you found an interesting bug, but I can't seem to reproduce it (the first query errors out for me, as it should). Can you run the following and see what's outputted?

$ fsql "SELECT * FROM . WHERE size > 1gb AND name LIKE mkv"

Also, does the output of the first query include any results where the size is less than 1 gigabyte?

[christiangenco]

$ fsql "SELECT * FROM . WHERE size > 1gb AND name LIKE mkv"
2017/06/14 14:44:37 strconv.ParseFloat: parsing "1gb": invalid syntax

FORMAT(size, GB) > 1 feels way grosser than size > 1gb - was there a technical reason for the change?

[kashav]

Sorry for the late response, been a little busy with school.

I do agree that the new syntax is not as clean/intuitive. The main reasoning behind this was to be more consistent between attribute modifiers (both in implementation and syntax).

Parsing the unit from the value itself required special consideration in the tokenizer, which I'd prefer to avoid. That being said, I'm all for re-adding that syntax if it could be implemented with the current modifier model (I'll definitely look into this!).

[christiangenco]

Check out how Crab does it:

select f1.bytes/1e6 as MB from files...