Updated Files #37
Open
Updated Files #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifpk
commented
May 12, 2023
quranref/scripts/.env
Outdated
| DB_NAME=quranref | ||
| DB_USERNAME=kashif | ||
| DB_PASSWORD=compulife | ||
| DB_COLLECTION=ayas |
There was a problem hiding this comment.
This is not required here as this is not a configuration setting. Wherever you create the DB, the collection names are still going to be the same.
quranref/scripts/cli.py
Outdated
| import typer | ||
| #from database_conn import * | ||
| from pyramid.paster import get_appsettings, setup_logging | ||
| from quranref.scripts.surah_info_import import * |
There was a problem hiding this comment.
import specific functions, variables from the module, don't use import *
quranref/scripts/database_conn.py
Outdated
| DB_NAME: str | ||
| DB_USERNAME: str | ||
| DB_PASSWORD: str | ||
| DB_COLLECTION: str |
There was a problem hiding this comment.
Again collection name is not going to change so using a variable for that doesn't make sense.
quranref/scripts/database_conn.py
Outdated
| db = client.db(settings.DB_NAME,username=settings.DB_USERNAME, password=settings.DB_PASSWORD) | ||
| #db =conn.Connection(username=settings.DB_USERNAME, password=settings.DB_PASSWORD).databases[settings.DB_NAME] | ||
| if not db.has_collection(settings.DB_COLLECTION): | ||
| ayasCollection = db.create_collection(settings.DB_COLLECTION) |
There was a problem hiding this comment.
inconsistent indentation. Use 4 spaces, not 8 spaces or tabs.
quranref/scripts/cli.py
Outdated
|
|
||
| @quranref_app.command("quranref_import_surah_info") | ||
| def quranref_scripts_surah_info_import(val:str): | ||
| surah_info_import("quranref_import_surah_info development.ini") |
There was a problem hiding this comment.
The aim was to create typer commands and not just call the existing scripts inside of of typer commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.