Missing call to executeTransactions()

[AndrejMitrovic]

pos-blockchain/blockchain/blockchain.js

Line 22 in 2e7ee09

console.log("NEW BLOCK ADDED");

Before this function returns, it should call this.executeTransactions(block);. This way the accounts are updated.

Btw, you wrote an excellent tutorial! It's really appreciated.

Cheers!

[kashishkhullar]

Thanks man, I had to complete it in a hurry, therefore there are lot of bugs. And I have been busy lately so i couldn't fix this stuff.

[kashishkhullar]

Create a PR and I'll merge it.

[ryan-rozario]

I think this part of the code needs to be changed.

pos-blockchain/blockchain/blockchain.js

Lines 22 to 27 in 2f91fe5

	addBlock(data) {
	let block = Block.createBlock(
	this.chain[this.chain.length - 1],
	data,
	new Wallet(secret)
	);

The part of the code shown below that calls this function actually passes a block object to the function.

pos-blockchain/blockchain/blockchain.js

Lines 80 to 89 in 2e7ee09

	isValidBlock(block) {
	const lastBlock = this.chain[this.chain.length - 1];
	if (
	block.lastHash === lastBlock.hash &&
	block.hash === Block.blockHash(block) &&
	Block.verifyBlock(block) &&
	Block.verifyLeader(block, this.getLeader())
	) {
	console.log("block valid");
	this.addBlock(block);

The block object was already created when the message was sent from the other node and there is no need to create a block again as you have done. You just have to add it to the chain as it was in the original code.