Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar UI issues under iOS 11 - XCode 9 #97

Closed
kasketis opened this issue Oct 14, 2017 · 6 comments
Closed

Search bar UI issues under iOS 11 - XCode 9 #97

kasketis opened this issue Oct 14, 2017 · 6 comments
Assignees
Labels

Comments

@kasketis
Copy link
Owner

iphone_7_-_ios_11_0

@kasketis kasketis added the bug label Oct 14, 2017
@Janglinator
Copy link
Contributor

You fixing this?

@kasketis
Copy link
Owner Author

Haven't found time yet! Any volunteers? 😃

@Janglinator
Copy link
Contributor

I will! Just didn’t want to step on your toes.

@kasketis
Copy link
Owner Author

Tested and works fine! 👍

@Janglinator
Copy link
Contributor

Haha I’m not much a fan of the new layout of it, but I couldn’t for the life of me find a workaround that still implemented UISearchController

@kasketis
Copy link
Owner Author

It's ok for now, at least better than before! We will come back to it in the future 👍

freak4pc added a commit to freak4pc/netfox that referenced this issue Oct 17, 2017
* kasketis/master:
  Minor changes related to kasketis#97
  Fixed issue kasketis#97: Search bar UI issues under iOS 11 - XCode 9
  We use layout guides in the project, which are only supported in iOS 9; increasing the minimum supported iOS version from 8 to 9
  Fixed build error  :) Cleaned up some warnings
  Changed loader name
  Fixed iOS 11 crash during search by annotating with objc the appropriate properties
  Updated gitignore
  Added new models
  Fixed a bug that managed to slip by my Swift 4 update.
  Ready to roll!
  Proof of concept
  Attempting to use Swift 4 lint
  Swift 4 compatibility
  Added a webview demo
  Added an iOS demo
  Added left close button in NFXListController_iOS + NFX.toggle()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants