Remove one define upsetting Boost 1.78.0 #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear tmbstan tean,
As discussed in eddelbuettel/bh#80 package BH would like to update to Boost 1.78. This is mostly smooth sailing but package
tmbstan
throws the truly bizarre error below. That is arguably a Boost error getting confused about its own define ... but alas simply removing it works.The PR does that. You should be safe with the PR as long as R builds are concerned as we'd always have BH to provide that 'one' version of Boost, otherweise you could to be fancier and inject the define for older versions.
It would be great if you could update
tmpstan
as we will likely ship a new BH soon. Let me know if you have questions.Thanks, Dirk