Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one define upsetting Boost 1.78.0 #21

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

eddelbuettel
Copy link
Contributor

Dear tmbstan tean,

As discussed in eddelbuettel/bh#80 package BH would like to update to Boost 1.78. This is mostly smooth sailing but package tmbstan throws the truly bizarre error below. That is arguably a Boost error getting confused about its own define ... but alas simply removing it works.

The PR does that. You should be safe with the PR as long as R builds are concerned as we'd always have BH to provide that 'one' version of Boost, otherweise you could to be fancier and inject the define for older versions.

It would be great if you could update tmpstan as we will likely ship a new BH soon. Let me know if you have questions.

Thanks, Dirk

In file included from /usr/local/lib/R/site-library/BH/include/boost/math/constants/constants.hpp:11,
                 from /home/dirk/tmp/lib/StanHeaders/include/stan/math/prim/scal/fun/constants.hpp:6,
                 from /home/dirk/tmp/lib/StanHeaders/include/stan/math/rev/core/operator_unary_plus.hpp:7,
                 from /home/dirk/tmp/lib/StanHeaders/include/stan/math/rev/core.hpp:38,
                 from /home/dirk/tmp/lib/StanHeaders/include/stan/math/rev/mat.hpp:6,
                 from /home/dirk/tmp/lib/StanHeaders/include/src/stan/model/log_prob_grad.hpp:4,
                 from /home/dirk/tmp/lib/StanHeaders/include/src/stan/model/test_gradients.hpp:7,
                 from /home/dirk/tmp/lib/StanHeaders/include/src/stan/services/diagnose/diagnose.hpp:10,
                 from /home/dirk/tmp/lib/rstan/include/rstan/stan_fit.hpp:35,                                                                                                                                      
                 from /home/dirk/tmp/lib/rstan/include/rstan/rstaninc.hpp:4,
                 from include/model.hpp:2,                                                               
                 from Modules.cpp:3:    
/usr/local/lib/R/site-library/BH/include/boost/math/tools/cxx03_warn.hpp:92:2: error: #error Support for C++03 has been removed. The minimum requirement for this library is fully compliant C++11.
   92 | #error Support for C++03 has been removed. The minimum requirement for this library is fully compliant C++11.
      |  ^~~~~                                      
make: *** [/usr/lib/R/etc/Makeconf:177: Modules.o] Error 1                                                                                                                                                         
ERROR: compilation failed for package ‘tmbstan’

@kaskr
Copy link
Owner

kaskr commented Dec 14, 2021

Thanks @eddelbuettel . I'll submit this to CRAN soon

@kaskr kaskr merged commit 1525472 into kaskr:master Dec 14, 2021
@eddelbuettel
Copy link
Contributor Author

Awesome! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants