Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy go files for test only package, to mitigate golang/go#27333 #1480

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

elichai
Copy link
Member

@elichai elichai commented Feb 2, 2021

Because of golang/go#27333 our coverage file is currently empty and failing, to mitigate this we just need a non-test go file in testing only packages

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1480 (7b0f8be) into v0.9.0-dev (97be133) will increase coverage by 61.58%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0.9.0-dev    #1480       +/-   ##
===============================================
+ Coverage            0   61.58%   +61.58%     
===============================================
  Files               0      508      +508     
  Lines               0    18928    +18928     
===============================================
+ Hits                0    11656    +11656     
- Misses              0     5621     +5621     
- Partials            0     1651     +1651     
Impacted Files Coverage Δ
domain/consensus/utils/txscript/error.go 88.88% <0.00%> (ø)
app/appmessage/rpc_notify_utxos_changed.go 85.71% <0.00%> (ø)
domain/consensus/utils/subnetworks/subnetworks.go 100.00% <0.00%> (ø)
app/app.go 0.00% <0.00%> (ø)
...pp/appmessage/p2p_msgibdblocklocatorhighesthash.go 100.00% <0.00%> (ø)
app/rpc/rpchandlers/unban.go 0.00% <0.00%> (ø)
infrastructure/logger/logs.go 57.33% <0.00%> (ø)
domain/miningmanager/mempool/error.go 10.52% <0.00%> (ø)
infrastructure/network/dnsseed/seed.go 0.00% <0.00%> (ø)
app/rpc/rpccontext/utxos_by_addresses.go 100.00% <0.00%> (ø)
... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97be133...f50def2. Read the comment docs.

someone235
someone235 previously approved these changes Feb 2, 2021
someone235
someone235 previously approved these changes Feb 2, 2021
@someone235 someone235 merged commit e7f9606 into v0.9.0-dev Feb 2, 2021
@someone235 someone235 deleted the fix-coverage branch February 2, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants