Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScriptPublicKey.Version to RPC responses of TransactionVerboseData #1559

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Feb 25, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1559 (a49c4f5) into v0.9.0-dev (24a12cf) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.9.0-dev    #1559      +/-   ##
==============================================
- Coverage       61.71%   61.66%   -0.05%     
==============================================
  Files             512      512              
  Lines           19486    19507      +21     
==============================================
+ Hits            12025    12029       +4     
- Misses           5749     5758       +9     
- Partials         1712     1720       +8     
Impacted Files Coverage Δ
app/appmessage/rpc_get_block.go 0.00% <ø> (ø)
app/rpc/rpccontext/verbosedata.go 73.52% <100.00%> (+0.26%) ⬆️
...apter/server/grpcserver/protowire/rpc_get_block.go 69.23% <100.00%> (+0.39%) ⬆️
domain/consensus/utils/subnetworks/from_string.go 0.00% <0.00%> (-50.00%) ⬇️
infrastructure/network/netadapter/router/route.go 78.57% <0.00%> (-14.29%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 53.84% <0.00%> (-5.77%) ⬇️
app/appmessage/domainconverters.go 90.10% <0.00%> (-2.96%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 70.00% <0.00%> (-2.50%) ⬇️
domain/consensus/utils/subnetworks/compare.go 100.00% <0.00%> (ø)
domain/consensus/model/externalapi/subnetworkid.go 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a12cf...32122b3. Read the comment docs.

@someone235 someone235 merged commit 089115c into v0.9.0-dev Feb 25, 2021
@someone235 someone235 deleted the rpc-script-public-key-version branch February 25, 2021 15:43
@elichai elichai linked an issue Mar 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptPubKey is missing a version in RPC
2 participants