Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EmitUnpopulated so that kaspactl prints all fields, including the ones with default value #1561

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Mar 1, 2021

No description provided.

@elichai elichai closed this Mar 1, 2021
@elichai elichai reopened this Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #1561 (9599a36) into v0.9.0-dev (103edf9) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.9.0-dev    #1561      +/-   ##
==============================================
+ Coverage       61.44%   61.46%   +0.02%     
==============================================
  Files             514      514              
  Lines           19682    19683       +1     
==============================================
+ Hits            12093    12098       +5     
+ Misses           5828     5824       -4     
  Partials         1761     1761              
Impacted Files Coverage Δ
cmd/kaspactl/main.go 0.00% <0.00%> (ø)
...nfrastructure/network/rpcclient/grpcclient/post.go 0.00% <0.00%> (ø)
infrastructure/network/addressmanager/store.go 77.06% <0.00%> (-1.84%) ⬇️
app/protocol/flows/blockrelay/ibd.go 76.14% <0.00%> (+0.91%) ⬆️
...ersselectedchainstore/headersselectedchainstore.go 73.78% <0.00%> (+2.91%) ⬆️
...ain/consensus/database/binaryserialization/hash.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103edf9...cae7830. Read the comment docs.

@elichai elichai merged commit df19bdf into v0.9.0-dev Mar 1, 2021
@elichai elichai deleted the emit-unpopulated branch March 1, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants