Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return RPC error if getBlock's lowHash doesn't exist #1569

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1569 (f8ea19e) into v0.9.0-dev (ce326b3) will decrease coverage by 0.04%.
The diff coverage is 14.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.9.0-dev    #1569      +/-   ##
==============================================
- Coverage       61.49%   61.45%   -0.05%     
==============================================
  Files             514      514              
  Lines           19687    19694       +7     
==============================================
- Hits            12107    12102       -5     
- Misses           5818     5826       +8     
- Partials         1762     1766       +4     
Impacted Files Coverage Δ
app/rpc/rpchandlers/get_blocks.go 32.65% <14.28%> (-3.07%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 53.84% <0.00%> (-3.85%) ⬇️
infrastructure/network/addressmanager/store.go 77.06% <0.00%> (-1.84%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 68.75% <0.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce326b3...f8ea19e. Read the comment docs.

@someone235 someone235 merged commit 05df6e3 into v0.9.0-dev Mar 2, 2021
@someone235 someone235 deleted the return-rpc-error-if-lowhash-doesnt-exist branch March 2, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants