Add the mempool size to getInfo RPC command #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svarogg
previously approved these changes
Mar 8, 2021
app/rpc/rpchandlers/get_info.go
Outdated
| response := appmessage.NewGetInfoResponseMessage(context.NetAdapter.ID().String()) | ||
| response := appmessage.NewGetInfoResponseMessage( | ||
| context.NetAdapter.ID().String(), | ||
| uint64(len(context.Domain.MiningManager().AllTransactions())), |
There was a problem hiding this comment.
Threre's no point making this uint64, if len returns int.
I'd make the thing int and save ourselves the cast
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1584 +/- ##
===============================================
- Coverage 59.92% 59.88% -0.04%
===============================================
Files 514 514
Lines 20260 20270 +10
===============================================
- Hits 12140 12138 -2
- Misses 6194 6206 +12
Partials 1926 1926
Continue to review full report at Codecov.
|
svarogg
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.