Adjust the difficulty in the first difficultyAdjustmentWindowSize blocks #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tWindowSize blocks
someone235
requested changes
Mar 10, 2021
| @@ -46,6 +50,13 @@ func (pmtm *pastMedianTimeManager) PastMedianTime(blockHash *externalapi.DomainH | |||
| if err != nil { | |||
| return 0, err | |||
| } | |||
| if len(window) == 0 { | |||
| header, err := pmtm.blockHeaderStore.BlockHeader(pmtm.databaseContext, pmtm.genesisHash) | |||
There was a problem hiding this comment.
It's very weird to check the window size and then give the timestamp of a hard coded hash. I would expect to choose between:
a. if window size is 0 -> return blockHash's timetstamp
b. if blockHash == genesis -> return genesis' timetstamp
There was a problem hiding this comment.
But it's not only the genesis, it's also any block pointing at the genesis
| if (shouldPass && err != nil) || (!shouldPass && !errors.Is(err, ruleerrors.ErrUnfinalizedTx)) { | ||
| t.Fatalf("Unexpected error: %+v", err) | ||
| t.Fatalf("ShouldPass: %t Unexpected error: %+v", shouldPass, err) |
someone235
approved these changes
Mar 10, 2021
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1592 +/- ##
===============================================
+ Coverage 59.89% 60.06% +0.16%
===============================================
Files 514 514
Lines 20255 20251 -4
===============================================
+ Hits 12132 12163 +31
+ Misses 6202 6163 -39
- Partials 1921 1925 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1546
The solution is this: #1546 (comment)