Adding DAA score #1596
Merged
Adding DAA score #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichai
reviewed
Mar 10, 2021
|
|
||
| // SerializeUint64 serializes a uint64 | ||
| func SerializeUint64(value uint64) []byte { | ||
| var keyBytes [8]byte |
There was a problem hiding this comment.
Replace the 8 here with uint64Length?
elichai
reviewed
Mar 10, 2021
| externalapi.DomainHashSize) | ||
| } | ||
|
|
||
| numHashes := len(hashesBytes) / externalapi.DomainHashSize |
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1596 +/- ##
===============================================
- Coverage 60.05% 59.95% -0.10%
===============================================
Files 514 515 +1
Lines 20236 20369 +133
===============================================
+ Hits 12152 12212 +60
- Misses 6175 6227 +52
- Partials 1909 1930 +21
Continue to review full report at Codecov.
|
elichai
reviewed
Mar 11, 2021
domain/consensus/factory.go
Outdated
| @@ -126,6 +127,7 @@ func (f *factory) NewConsensus(dagParams *dagconfig.Params, db infrastructuredat | |||
| headersSelectedTipStore := headersselectedtipstore.New() | |||
| finalityStore := finalitystore.New(200, preallocateCaches) | |||
| headersSelectedChainStore := headersselectedchainstore.New(pruningWindowSizeForCaches, preallocateCaches) | |||
| daaBlocksStore := daablocksstore.New(pruningWindowSizeForCaches, preallocateCaches) | |||
There was a problem hiding this comment.
Maybe split the cache size to 2:
- DAA score at size: pruningWindowSizeForCaches.
- Derge Set for FinalityWindow only.
elichai
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1259