In RPC, use RPCTransactions and RPCBlocks instead of TransactionMessages and BlockMessages #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1609 +/- ##
===============================================
- Coverage 60.41% 60.32% -0.10%
===============================================
Files 533 533
Lines 20687 20702 +15
===============================================
- Hits 12499 12489 -10
- Misses 6233 6255 +22
- Partials 1955 1958 +3
Continue to review full report at Codecov.
|
# Conflicts: # infrastructure/network/netadapter/server/grpcserver/protowire/rpc.pb.go # infrastructure/network/netadapter/server/grpcserver/protowire/rpc.proto
…d protowire.RpcTransaction.
someone235
requested changes
Mar 30, 2021
app/appmessage/domainconverters.go
Outdated
| } | ||
| } | ||
|
|
||
| // RPCBlockToDomainBlock converts RPCBlocks to DomainBlocks |
There was a problem hiding this comment.
RPCBlocks -> RPCBlock, DomainBlocks -> DomainBlock
app/rpc/rpccontext/verbosedata.go
Outdated
| Hash: blockHash.String(), | ||
| Difficulty: ctx.GetDifficultyRatio(domainBlockHeader.Bits(), ctx.Config.ActiveNetParams), | ||
| ChildrenHashes: hashes.ToStrings(childrenHashes), | ||
| SelectedParentHash: "", // TODO |
someone235
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1247