Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Services field from NetAddress #1610

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

stasatdaglabs
Copy link
Collaborator

This resolves #1119

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1610 (7470bfd) into v0.10.0-dev (d9449a3) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0.10.0-dev    #1610      +/-   ##
===============================================
- Coverage        60.03%   60.01%   -0.02%     
===============================================
  Files              515      515              
  Lines            20464    20455       -9     
===============================================
- Hits             12286    12277       -9     
  Misses            6228     6228              
  Partials          1950     1950              
Impacted Files Coverage Δ
app/rpc/rpchandlers/unban.go 0.00% <0.00%> (ø)
infrastructure/network/connmanager/connmanager.go 43.20% <0.00%> (ø)
infrastructure/network/dnsseed/seed.go 0.00% <0.00%> (ø)
...k/netadapter/server/grpcserver/protowire/common.go 68.42% <ø> (-0.81%) ⬇️
...ture/network/addressmanager/localaddressmanager.go 45.85% <60.00%> (-0.30%) ⬇️
app/appmessage/p2p_netaddress.go 100.00% <100.00%> (ø)
infrastructure/network/addressmanager/store.go 78.30% <100.00%> (-0.60%) ⬇️
...nfrastructure/network/addressmanager/test_utils.go 45.45% <100.00%> (ø)
infrastructure/network/netadapter/netconnection.go 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9449a3...31ae5a9. Read the comment docs.

@someone235 someone235 merged commit cbd0bb6 into v0.10.0-dev Mar 16, 2021
@someone235 someone235 deleted the remove-netaddress-services branch March 16, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants