Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getBlocks to not add the anticone when some blocks were filtered by GetHashesBetween #1611

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

someone235
Copy link
Collaborator

Otherwise there can be a situation you get a block in the anticone without getting its parents first

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1611 (d3f96a3) into v0.10.0-dev (cbd0bb6) will decrease coverage by 0.00%.
The diff coverage is 45.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0.10.0-dev    #1611      +/-   ##
===============================================
- Coverage        60.02%   60.02%   -0.01%     
===============================================
  Files              515      515              
  Lines            20455    20454       -1     
===============================================
- Hits             12279    12278       -1     
+ Misses            6227     6226       -1     
- Partials          1949     1950       +1     
Impacted Files Coverage Δ
domain/consensus/processes/syncmanager/antipast.go 40.74% <25.00%> (-0.44%) ⬇️
domain/consensus/consensus.go 64.62% <50.00%> (ø)
...rotocol/flows/blockrelay/handle_request_headers.go 68.29% <100.00%> (ø)
app/rpc/rpchandlers/get_blocks.go 32.65% <100.00%> (ø)
...ain/consensus/processes/syncmanager/syncmanager.go 100.00% <100.00%> (ø)
...k/netadapter/server/grpcserver/connection_loops.go 53.84% <0.00%> (-3.85%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 70.00% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd0bb6...2e04776. Read the comment docs.

@someone235 someone235 merged commit b84080f into v0.10.0-dev Mar 16, 2021
@someone235 someone235 deleted the fix-get-blocks branch March 16, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants