Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the HomeDir flag with a AppDir flag #1615

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Replace the HomeDir flag with a AppDir flag #1615

merged 1 commit into from
Mar 17, 2021

Conversation

elichai
Copy link
Member

@elichai elichai commented Mar 17, 2021

#1613 restructured the default directory, but used the name homedir to represent it, which is ambiguous with ~/ or $HOME.
so this renames it to appdir which should be less ambiguous

@elichai elichai added this to the 0.10.0 milestone Mar 17, 2021
@elichai elichai added this to In progress in Mainnet via automation Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #1615 (964a4b3) into v0.10.0-dev (1a4161f) will increase coverage by 0.02%.
The diff coverage is 25.00%.

❗ Current head 964a4b3 differs from pull request most recent head 5cf1284. Consider uploading reports for the commit 5cf1284 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           v0.10.0-dev    #1615      +/-   ##
===============================================
+ Coverage        59.98%   60.01%   +0.02%     
===============================================
  Files              515      515              
  Lines            20454    20454              
===============================================
+ Hits             12270    12275       +5     
+ Misses            6234     6229       -5     
  Partials          1950     1950              
Impacted Files Coverage Δ
app/app.go 0.00% <0.00%> (ø)
cmd/kaspaminer/config.go 0.00% <ø> (ø)
infrastructure/config/config.go 11.11% <16.66%> (ø)
util/appdata.go 86.66% <100.00%> (ø)
infrastructure/network/addressmanager/store.go 78.30% <0.00%> (+1.88%) ⬆️
...ersselectedchainstore/headersselectedchainstore.go 71.02% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4161f...5cf1284. Read the comment docs.

@svarogg svarogg merged commit caf251b into v0.10.0-dev Mar 17, 2021
Mainnet automation moved this from In progress to Done Mar 17, 2021
@svarogg svarogg deleted the appdir branch March 17, 2021 10:48
@elichai elichai added this to Done in Mainnet May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants