Use BLAKE2B instead of HASH160, and get rid of any usage of RIPEMD160 and SHA1 #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1618 +/- ##
===============================================
- Coverage 60.01% 59.92% -0.09%
===============================================
Files 516 516
Lines 20494 20476 -18
===============================================
- Hits 12299 12270 -29
- Misses 6241 6250 +9
- Partials 1954 1956 +2
Continue to review full report at Codecov.
|
stasatdaglabs
requested changes
Mar 17, 2021
| "", | ||
| "OK" | ||
| ], | ||
| [ | ||
| "0", | ||
| "SHA1", | ||
| "SHA256", | ||
| "", | ||
| "OK" | ||
| ], |
There was a problem hiding this comment.
This test case is a duplicate of the one above it.
| "", | ||
| "INVALID_STACK_OPERATION" | ||
| ], | ||
| [ | ||
| "", | ||
| "SHA1", | ||
| "SHA256", | ||
| "", | ||
| "INVALID_STACK_OPERATION" | ||
| ], |
There was a problem hiding this comment.
This test case is a duplicate of the one above it.
| "", | ||
| "INVALID_STACK_OPERATION" | ||
| ], | ||
| [ | ||
| "", | ||
| "SHA1 1", | ||
| "SHA256 1", | ||
| "", | ||
| "INVALID_STACK_OPERATION" | ||
| ], |
There was a problem hiding this comment.
This test case is a duplicate of the one above it.
util/hash160.go
Outdated
| @@ -5,19 +5,11 @@ | |||
| package util | |||
There was a problem hiding this comment.
I think you might want to rename this file.
stasatdaglabs
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1023