Replace ECMH with Muhash #1624
Merged
Replace ECMH with Muhash #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1624 +/- ##
===============================================
- Coverage 59.97% 59.92% -0.06%
===============================================
Files 516 516
Lines 20471 20469 -2
===============================================
- Hits 12278 12266 -12
- Misses 6238 6246 +8
- Partials 1955 1957 +2
Continue to review full report at Codecov.
|
svarogg
requested changes
Mar 22, 2021
domain/dagconfig/genesis.go
Outdated
| @@ -101,10 +102,10 @@ var devnetGenesisBlock = externalapi.DomainBlock{ | |||
| []*externalapi.DomainHash{}, | |||
| devnetGenesisMerkleRoot, | |||
| &externalapi.DomainHash{}, | |||
| &externalapi.DomainHash{}, | |||
| externalapi.NewDomainHashFromByteArray((*[32]byte)(&muhash.EmptyMuHashHash)), | |||
There was a problem hiding this comment.
It could be nice if Hash would have .ToArray() or something to save the (*[32]byte) ugliness
svarogg
requested changes
Mar 22, 2021
| @@ -21,28 +22,27 @@ func (m multiset) Remove(data []byte) { | |||
|
|
|||
| func (m multiset) Hash() *externalapi.DomainHash { | |||
| finalizedHash := m.ms.Finalize() | |||
| finalizedHashAsByteArray := (*[secp256k1.HashSize]byte)(finalizedHash) | |||
| return externalapi.NewDomainHashFromByteArray(finalizedHashAsByteArray) | |||
| finalizedHashAsByteArray := ([secp256k1.HashSize]byte)(finalizedHash) | |||
There was a problem hiding this comment.
You can use .AsArray here I think
svarogg
previously approved these changes
Mar 22, 2021
svarogg
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine(without turbo 2.4Ghz), ECMH:
MuHash:
And potentially if we add assembly implementations using SSE2/SSE4.1/AVX this can get even faster.
Note that the MuHash code isn't audited or reviewed and need to be audited before we go to mainnet.