Add mass limit to mempool #1627
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1627 +/- ##
===============================================
+ Coverage 60.40% 60.41% +0.01%
===============================================
Files 533 533
Lines 20684 20687 +3
===============================================
+ Hits 12495 12499 +4
+ Misses 6234 6233 -1
Partials 1955 1955
Continue to review full report at Codecov.
|
domain/miningmanager/factory.go
Outdated
| func (f *factory) NewMiningManager(consensus externalapi.Consensus, blockMaxMass uint64, acceptNonStd bool) MiningManager { | ||
| mempool := mempoolpkg.New(consensus, acceptNonStd) | ||
| func (f *factory) NewMiningManager(consensus externalapi.Consensus, blockMaxMass uint64, acceptNonStd bool, params *dagconfig.Params) MiningManager { | ||
| mempool := mempoolpkg.New(consensus, acceptNonStd, params) |
There was a problem hiding this comment.
It appears that the only reason why you're passing the entire params into the mempool is for MaxMassAcceptedByBlock.
You've already passed MaxMassAcceptedByBlock into NewMiningManager, (it's blockMaxMass) so why not just pass that into the mempool instead?
…d into add-mass-limit-to-mempool
No description provided.