Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do resolveSingleBlockStatus in a separate StagingArea to prevent huge db transaction #1634

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Mar 25, 2021

This fixes #1516

@svarogg svarogg linked an issue Mar 25, 2021 that may be closed by this pull request
@svarogg svarogg force-pushed the 1516-big-reorgs-lots-of-memory branch from 7bcb99e to e9de404 Compare March 25, 2021 13:02
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1634 (094a406) into v0.10.0-dev (2abc284) will decrease coverage by 0.11%.
The diff coverage is 71.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v0.10.0-dev    #1634      +/-   ##
===============================================
- Coverage        60.19%   60.07%   -0.12%     
===============================================
  Files              532      533       +1     
  Lines            20676    20684       +8     
===============================================
- Hits             12446    12426      -20     
- Misses            6274     6305      +31     
+ Partials          1956     1953       -3     
Impacted Files Coverage Δ
util/staging/commit_all_changes.go 55.55% <55.55%> (ø)
...sses/consensusstatemanager/resolve_block_status.go 72.85% <80.00%> (+0.12%) ⬆️
...processes/blockprocessor/validateandinsertblock.go 70.90% <100.00%> (+0.79%) ⬆️
...onsensus/processes/blockprocessor/validateblock.go 88.57% <100.00%> (ø)
...consensus/database/serialization/acceptancedata.go 41.46% <0.00%> (-36.59%) ⬇️
...tures/acceptancedatastore/acceptance_data_store.go 45.16% <0.00%> (-22.59%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 53.84% <0.00%> (-3.85%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 68.75% <0.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abc284...094a406. Read the comment docs.

@svarogg svarogg force-pushed the 1516-big-reorgs-lots-of-memory branch from e9de404 to 9f28130 Compare March 29, 2021 07:40
@svarogg svarogg changed the title DO NOT MERGE!!! Do resolveSingleBlockStatus in a separate StagingArea to prevent huge db transaction Do resolveSingleBlockStatus in a separate StagingArea to prevent huge db transaction Mar 29, 2021
@someone235 someone235 merged commit 4e18031 into v0.10.0-dev Mar 30, 2021
@someone235 someone235 deleted the 1516-big-reorgs-lots-of-memory branch March 30, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big reorgs take a lot of memory
2 participants