Add a show-address subcommand to kaspawallet #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1653 +/- ##
===============================================
- Coverage 59.95% 59.93% -0.02%
===============================================
Files 542 543 +1
Lines 21286 21305 +19
===============================================
+ Hits 12761 12770 +9
- Misses 6522 6536 +14
+ Partials 2003 1999 -4
Continue to review full report at Codecov.
|
svarogg
requested changes
Apr 5, 2021
cmd/kaspawallet/config.go
Outdated
| @@ -63,6 +64,11 @@ type broadcastConfig struct { | |||
| config.NetworkFlags | |||
| } | |||
|
|
|||
| type showAddressConfig struct { | |||
| KeysFile string `long:"keys-file" short:"f" description:"Keys file location (only if different from default)"` | |||
There was a problem hiding this comment.
Instead of "(only if different from default)" better to write something like "(default: ~/.kaspawallet/blabla.json)".
svarogg
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.