Add ECDSA support to the wallet #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasatdaglabs
requested changes
Apr 6, 2021
| if err != nil { | ||
| return nil, nil, errors.Wrap(err, "Failed to generate public key") | ||
| return nil, errors.Wrap(err, "Failed to deserialized private key") |
There was a problem hiding this comment.
Typo: deserialized -> deserialize
cmd/kaspawallet/keys/keys.go
Outdated
| @@ -62,11 +64,13 @@ func (d *Data) toJSON() *keysFileJSON { | |||
| EncryptedPrivateKeys: encryptedPrivateKeysJSON, | |||
| PublicKeys: publicKeysHex, | |||
| MinimumSignatures: d.MinimumSignatures, | |||
| ECDSA: d.ECDSA, | |||
| } | |||
| } | |||
|
|
|||
| func (d *Data) fromJSON(kfj *keysFileJSON) error { | |||
There was a problem hiding this comment.
Please avoid using abbreviations in non-receiver variable names.
stasatdaglabs
approved these changes
Apr 6, 2021
Codecov Report
@@ Coverage Diff @@
## v0.10.0-dev #1664 +/- ##
===============================================
+ Coverage 59.34% 59.62% +0.27%
===============================================
Files 547 548 +1
Lines 21653 21695 +42
===============================================
+ Hits 12851 12936 +85
+ Misses 6779 6714 -65
- Partials 2023 2045 +22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1664