Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate virtual's acceptance data and multiset after importing a new pruning point #1700

Merged

Conversation

someone235
Copy link
Collaborator

@someone235 someone235 commented May 5, 2021

Fixes #1699

@someone235 someone235 linked an issue May 5, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1700 (cc0b652) into v0.10.1-dev (ccfe8a4) will increase coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head cc0b652 differs from pull request most recent head 80753f6. Consider uploading reports for the commit 80753f6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           v0.10.1-dev    #1700      +/-   ##
===============================================
+ Coverage        59.41%   59.44%   +0.02%     
===============================================
  Files              551      551              
  Lines            21930    21940      +10     
===============================================
+ Hits             13030    13042      +12     
+ Misses            6825     6821       -4     
- Partials          2075     2077       +2     
Impacted Files Coverage Δ
...processor/validateandinsertimportedpruningpoint.go 71.05% <50.00%> (-3.95%) ⬇️
app/protocol/flows/blockrelay/handle_relay_invs.go 70.00% <0.00%> (+1.25%) ⬆️
...selectedchainstore/headers_selected_chain_store.go 70.00% <0.00%> (+4.28%) ⬆️
...ain/consensus/database/binaryserialization/hash.go 70.58% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfe8a4...80753f6. Read the comment docs.

@someone235 someone235 force-pushed the calc-virtual-acceptance-after-importing-point branch from 2bf28e4 to 0e0525f Compare May 5, 2021 14:50
@someone235 someone235 force-pushed the calc-virtual-acceptance-after-importing-point branch from 0e0525f to 80753f6 Compare May 5, 2021 14:51
@someone235 someone235 merged commit b405ea5 into v0.10.1-dev May 5, 2021
@someone235 someone235 deleted the calc-virtual-acceptance-after-importing-point branch May 5, 2021 15:13
@someone235 someone235 restored the calc-virtual-acceptance-after-importing-point branch May 5, 2021 15:41
@stasatdaglabs stasatdaglabs mentioned this pull request May 9, 2021
stasatdaglabs pushed a commit that referenced this pull request May 11, 2021
@someone235 someone235 deleted the calc-virtual-acceptance-after-importing-point branch June 7, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during IBD
2 participants