Fix getBlock and getBlocks RPC commands to return blocks and transactions properly #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.10.2-dev #1716 +/- ##
===============================================
- Coverage 59.43% 59.37% -0.06%
===============================================
Files 551 551
Lines 21943 21962 +19
===============================================
Hits 13041 13041
- Misses 6825 6844 +19
Partials 2077 2077
Continue to review full report at Codecov.
|
someone235
force-pushed
the
fix-get-block-to-return-transactions
branch
from
5386022
to
4f74ba2
Compare
stasatdaglabs
requested changes
May 13, 2021
domain/consensus/consensus.go
Outdated
| if errors.Is(err, database.ErrNotFound) { | ||
| header, err := s.blockHeaderStore.BlockHeader(s.databaseContext, stagingArea, blockHash) | ||
| if err != nil { | ||
| if errors.Is(err, database.ErrNotFound) { |
There was a problem hiding this comment.
Instead of building a pyramid, please exit out of the function when err is not ErrNotFound.
someone235
force-pushed
the
fix-get-block-to-return-transactions
branch
from
ec25a15
to
f7f80b2
Compare
someone235
force-pushed
the
fix-get-block-to-return-transactions
branch
from
f7f80b2
to
0d8589a
Compare
stasatdaglabs
approved these changes
May 13, 2021
stasatdaglabs
pushed a commit
that referenced
this pull request
May 13, 2021
…ions properly (#1716) * Fix getBlock RPC command to return transactions * Fix getBlocks RPC command to return transactions and blocks * Add GetBlockEvenIfHeaderOnly and use it for getBlock and getBlocks * Implement GetBlockEvenIfHeaderOnly for fakeRelayInvsContext * Use less nested code (cherry picked from commit 50fd86e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.