Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to nameless routes #1986

Merged
merged 3 commits into from Mar 28, 2022
Merged

Add names to nameless routes #1986

merged 3 commits into from Mar 28, 2022

Conversation

Aleoami
Copy link
Contributor

@Aleoami Aleoami commented Mar 23, 2022

Adding names to nameless routes of capacity of 131172 to avoid messages like "route '' reached capacity of 131172" where it's unclear what exactly this route is.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1986 (ce1bd9a) into dev (58d627e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1986      +/-   ##
==========================================
- Coverage   57.24%   57.24%   -0.01%     
==========================================
  Files         680      680              
  Lines       32737    32737              
==========================================
- Hits        18741    18739       -2     
- Misses      11330    11334       +4     
+ Partials     2666     2664       -2     
Impacted Files Coverage Δ
infrastructure/network/netadapter/netadapter.go 75.58% <100.00%> (ø)
infrastructure/network/netadapter/netconnection.go 94.28% <100.00%> (ø)
infrastructure/network/netadapter/router/router.go 84.12% <100.00%> (ø)
infrastructure/network/rpcclient/rpcrouter.go 85.71% <100.00%> (ø)
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️
...selectedchainstore/headers_selected_chain_store.go 72.09% <0.00%> (-3.49%) ⬇️
infrastructure/network/addressmanager/store.go 77.84% <0.00%> (-1.27%) ⬇️
infrastructure/network/rpcclient/rpcclient.go 67.41% <0.00%> (+4.49%) ⬆️
infrastructure/network/netadapter/router/route.go 88.57% <0.00%> (+5.71%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d627e...ce1bd9a. Read the comment docs.

@Aleoami Aleoami marked this pull request as ready for review March 23, 2022 10:53
@Aleoami Aleoami changed the title add names to nameless routes Add names to nameless routes Mar 23, 2022
@someone235 someone235 merged commit 2eca0f0 into kaspanet:dev Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants