Validate GetBlockTemplate extra data #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
force-pushed
the
validate-gbt-extra-data
branch
from
9b594a2
to
c97a112
Compare
| @@ -27,6 +27,11 @@ func HandleGetBlockTemplate(context *rpccontext.Context, _ *router.Router, reque | |||
| } | |||
|
|
|||
| coinbaseData := &externalapi.DomainCoinbaseData{ScriptPublicKey: scriptPublicKey, ExtraData: []byte(version.Version() + "/" + getBlockTemplateRequest.ExtraData)} | |||
| if uint64(len(coinbaseData.ExtraData)) > context.Config.NetParams().MaxCoinbasePayloadLength { | |||
There was a problem hiding this comment.
I think you need to check len(ExtraData) + len(script) + script constants
Codecov Report
@@ Coverage Diff @@
## dev #1997 +/- ##
=======================================
Coverage 57.15% 57.16%
=======================================
Files 685 685
Lines 32995 33023 +28
=======================================
+ Hits 18859 18877 +18
- Misses 11452 11462 +10
Partials 2684 2684
Continue to review full report at Codecov.
|
michaelsutton
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.