New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaspawallet daemon: Add Send and Sign commands #2016
Kaspawallet daemon: Add Send and Sign commands #2016
Conversation
cmd/kaspawallet/broadcast.go
Outdated
if err != nil { | ||
return err | ||
} | ||
fmt.Println("Transaction was sent successfully") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Transactions were"
} | ||
|
||
message ShutdownRequest { | ||
} | ||
|
||
message ShutdownResponse { | ||
} | ||
|
||
message SendRequest{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment that explains that this should be used only on trusted or secured connection?
repeated string txIDs = 1; | ||
} | ||
|
||
message SignRequest{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment that explains that this should be used only on trusted or secured connection?
cmd/kaspawallet/send.go
Outdated
if err != nil { | ||
return err | ||
} | ||
fmt.Println("Transaction was sent successfully") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Transactions were"
…/kaspad into kaspawallet-daemon-send-and-sign
Codecov Report
@@ Coverage Diff @@
## dev #2016 +/- ##
==========================================
- Coverage 61.60% 59.56% -2.04%
==========================================
Files 627 665 +38
Lines 29502 31595 +2093
==========================================
+ Hits 18176 18821 +645
- Misses 8751 10084 +1333
- Partials 2575 2690 +115
Continue to review full report at Codecov.
|
This PR adds the Send and Sign commands to the kaspawallet daemon, to be used by external wallets and APIs.
Requested by TxBit exchange.