Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaspawallet daemon: Add Send and Sign commands #2016

Merged
merged 10 commits into from Apr 11, 2022

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Apr 10, 2022

This PR adds the Send and Sign commands to the kaspawallet daemon, to be used by external wallets and APIs.
Requested by TxBit exchange.

if err != nil {
return err
}
fmt.Println("Transaction was sent successfully")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Transactions were"

}

message ShutdownRequest {
}

message ShutdownResponse {
}

message SendRequest{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that explains that this should be used only on trusted or secured connection?

repeated string txIDs = 1;
}

message SignRequest{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that explains that this should be used only on trusted or secured connection?

if err != nil {
return err
}
fmt.Println("Transaction was sent successfully")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Transactions were"

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2016 (f458e1b) into dev (14b2bcb) will decrease coverage by 2.03%.
The diff coverage is 47.05%.

❗ Current head f458e1b differs from pull request most recent head 869a710. Consider uploading reports for the commit 869a710 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2016      +/-   ##
==========================================
- Coverage   61.60%   59.56%   -2.04%     
==========================================
  Files         627      665      +38     
  Lines       29502    31595    +2093     
==========================================
+ Hits        18176    18821     +645     
- Misses       8751    10084    +1333     
- Partials     2575     2690     +115     
Impacted Files Coverage Δ
app/app.go 0.00% <0.00%> (ø)
app/appmessage/error.go 0.00% <0.00%> (ø)
app/appmessage/message.go 71.42% <ø> (ø)
app/appmessage/p2p_msgrequestanticone.go 0.00% <0.00%> (ø)
..._msgrequestnextpruningpointanditsanticoneblocks.go 0.00% <0.00%> (ø)
app/appmessage/protocol.go 100.00% <ø> (ø)
app/appmessage/rpc_get_balances_by_addresses.go 0.00% <0.00%> (ø)
app/appmessage/rpc_submit_block.go 83.33% <ø> (ø)
app/protocol/flowcontext/errors.go 26.66% <0.00%> (-13.34%) ⬇️
app/protocol/flows/handshake/handshake.go 44.89% <ø> (ø)
... and 209 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357e8ce...869a710. Read the comment docs.

@someone235 someone235 merged commit ada559f into kaspanet:dev Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants