Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet output in send/broadcast cmd #2032

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

biospb
Copy link
Contributor

@biospb biospb commented Apr 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2032 (c8a5443) into dev (6e2fd06) will increase coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head c8a5443 differs from pull request most recent head f7dfb0a. Consider uploading reports for the commit f7dfb0a to get more accurate results

@@            Coverage Diff             @@
##              dev    #2032      +/-   ##
==========================================
+ Coverage   59.44%   59.57%   +0.12%     
==========================================
  Files         675      675              
  Lines       32201    32225      +24     
==========================================
+ Hits        19142    19197      +55     
+ Misses      10306    10274      -32     
- Partials     2753     2754       +1     
Impacted Files Coverage Δ
cmd/kaspawallet/broadcast.go 0.00% <0.00%> (ø)
cmd/kaspawallet/send.go 0.00% <0.00%> (ø)
cmd/kaspactl/commands.go 0.00% <0.00%> (ø)
infrastructure/network/addressmanager/store.go 79.11% <0.00%> (+1.26%) ⬆️
infrastructure/network/rpcclient/rpcclient.go 65.16% <0.00%> (+2.24%) ⬆️
...rver/grpcserver/protowire/rpc_get_mempool_entry.go 72.72% <0.00%> (+6.06%) ⬆️
app/rpc/rpc.go 70.83% <0.00%> (+6.94%) ⬆️
...ructure/network/rpcclient/rpc_get_mempool_entry.go 63.63% <0.00%> (+18.18%) ⬆️
...tures/acceptancedatastore/acceptance_data_store.go 73.17% <0.00%> (+19.51%) ⬆️
app/rpc/rpchandlers/get_mempool_entry.go 64.70% <0.00%> (+23.52%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2fd06...f7dfb0a. Read the comment docs.

someone235
someone235 previously approved these changes Apr 26, 2022
@someone235 someone235 changed the base branch from master to dev April 26, 2022 22:19
@someone235 someone235 dismissed their stale review April 26, 2022 22:19

The base branch was changed.

@someone235 someone235 merged commit 8d5faee into kaspanet:dev Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants