Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finality check to ResolveVirtual #2041

Merged

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2041 (2c9f837) into dev (7390651) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##              dev    #2041      +/-   ##
==========================================
- Coverage   59.42%   59.41%   -0.01%     
==========================================
  Files         674      674              
  Lines       32237    32244       +7     
==========================================
+ Hits        19158    19159       +1     
- Misses      10326    10330       +4     
- Partials     2753     2755       +2     
Impacted Files Coverage Δ
...nsensus/processes/consensusstatemanager/resolve.go 54.54% <71.42%> (+1.68%) ⬆️
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
infrastructure/network/netadapter/netadapter.go 75.58% <0.00%> (-4.66%) ⬇️
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.44% <0.00%> (+0.40%) ⬆️
...ructure/network/rpcclient/grpcclient/grpcclient.go 81.25% <0.00%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7390651...2c9f837. Read the comment docs.

@someone235 someone235 force-pushed the add-finality-check-to-resolve-virtual branch from 5d47dbf to 18389af Compare May 5, 2022 17:38
@michaelsutton michaelsutton merged commit c839337 into kaspanet:dev May 5, 2022
@someone235 someone235 deleted the add-finality-check-to-resolve-virtual branch May 5, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants