Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory message about the mnemonic(s) at the wallet creation (closing issue #2010) #2047

Merged
merged 2 commits into from
May 25, 2022

Conversation

Aleoami
Copy link
Contributor

@Aleoami Aleoami commented May 11, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #2047 (b41d238) into dev (cd5fd86) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head b41d238 differs from pull request most recent head e6a40fa. Consider uploading reports for the commit e6a40fa to get more accurate results

@@            Coverage Diff             @@
##              dev    #2047      +/-   ##
==========================================
+ Coverage   59.38%   59.44%   +0.06%     
==========================================
  Files         674      673       -1     
  Lines       32371    32254     -117     
==========================================
- Hits        19222    19173      -49     
+ Misses      10386    10324      -62     
+ Partials     2763     2757       -6     
Impacted Files Coverage Δ
cmd/kaspawallet/create.go 0.00% <0.00%> (ø)
cmd/kaspawallet/keys/create.go 0.00% <0.00%> (ø)
...tructure/network/rpcclient/rpc_on_chain_changed.go 52.38% <0.00%> (-14.29%) ⬇️
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
...pc_get_virtual_selected_parent_chain_from_block.go 64.81% <0.00%> (-10.19%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️
...selectedchainstore/headers_selected_chain_store.go 72.09% <0.00%> (-3.49%) ⬇️
app/rpc/manager.go 69.23% <0.00%> (-2.87%) ⬇️
domain/domain.go 52.29% <0.00%> (-1.69%) ⬇️
infrastructure/network/addressmanager/store.go 77.84% <0.00%> (-1.27%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0521938...e6a40fa. Read the comment docs.

@Aleoami Aleoami marked this pull request as ready for review May 16, 2022 22:11
@svarogg
Copy link
Collaborator

svarogg commented May 17, 2022

lgtm

@michaelsutton michaelsutton merged commit 968d47c into kaspanet:dev May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants