-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rustc 1.77 issues and lints #442
Conversation
fix seal macro hash error due to rustc 1.77 fix all rustc 1.77 lints
@@ -56,7 +56,7 @@ impl std::fmt::Display for AccountId { | |||
} | |||
} | |||
|
|||
seal! { 0xa7a4, { | |||
seal! { 0x544d, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it only works with version 1.77 we have to introduce msrv equals 1.77 in manifest files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSRV added: ad701e1
|
||
pub struct SessionReadGuard<'a>(RfRwLockReadGuard<'a>); | ||
pub struct SessionReadGuard<'a>(pub RfRwLockReadGuard<'a>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this change occur due to inter?
If so I would suggest to suppress it instead of making the field public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed: 319a624
it doesn't work properly |
propagated |
This replicates #438 (unfortunately I can't merge this due to other lint errors, so if this merged #438 should be closed)